The latest updates on your projects. Learn more about Vercel for Git ↗︎

Size Change: +3.99 kB (+0.13%)

Total Size: 3.19 MB

_{compressed-size-action}

So... I finally had a look, and I think we're most of the way there.

One more thing: there's a chance if you don't opt in, that the event collector will collect forever. Is there ever a "definitely opted out" event to hook into, which would stop it?

One more thing: there's a chance if you don't opt in, that the event collector will collect forever. Is there ever a "definitely opted out" event to hook into, which would stop it?

That is not a thing. It's either user is opted in/out by default and consent has been toggled.

Currently, we'll clear the missedInvocations queue after we've loaded all of the site_app's and set loaded to true (this will include cases where consent wasn't given and site_destination's haven't been loaded yet), which will disable the eventCollector.

We could reuse the missedInvocations queue to only clear after all site_destination's have been loaded and consentIsGiven, since it's already configured to only hold 1000 events at a time?

if (this.missedInvocations.length > 1000) {
    this.missedInvocations = this.missedInvocations.slice(10)
}

Wait... so what happens if:

• User clicks on an ad and lands on a site
• Waits 30seconds before clicking "agree to cookies and stuff" (all JS loads within the first 5sec)
• what happens now?

They way I understand the last comment, is that they won't count as a converted user (we drop all events captured, as when site apps finished loading, we didn't have consent yet). Is that how it works, or did I misunderstand something again? If that is how it works though, it's definitely far from ideal and needs fixing.

Sorry to be a pain but I will really want to get this in first

I updated the code to save initial campaign/referrer props parameters to this.storage.

1. persistence: 'memory' & isOptedOut: true
2. User visits posthog.com?gclid=ad_click_1
   • We won't capture a $pageview event, but we'll store gclid: 'ad_click_1' in memory
3. User visits the pricing page
   • URL changes to posthog.com/pricing
4. User accepts the cookie banner (posthog.opt_in_capturing() & posthog.set_config({ persistence: 'localStorage+cookie' }))
   • We'll send an initial $pageview event and since the gclid is stored in this.storage we'll append that as an event property. Will also be included as an $initial_ person property.
5. User visits the signup page - we capture a $pageview event
   • This event will be captured normally

If the user reloads the page between step 2 - 4 we'll lose the gclid property.